python312Packages.scalene: fix build on Linux and Darwin#326169
Merged
superherointj merged 1 commit intoNixOS:masterfrom Jul 11, 2024
Merged
python312Packages.scalene: fix build on Linux and Darwin#326169superherointj merged 1 commit intoNixOS:masterfrom
superherointj merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
11.by: package-maintainer
sarahec
force-pushed
the
scalene-no-nvidia-ml-py3
branch
from
24a65f5 to
faf50ff
Compare
Contributor
|
Other than the above comment, tested locally and it lgtm |
Contributor
|
@sarahec Please run |
sarahec
force-pushed
the
scalene-no-nvidia-ml-py3
branch
from
faf50ff to
f08d1e0
Compare
Contributor
Author
Done. I've now switched my formatter to
Done. Thank you for your help! |
Contributor
|
Result of 4 packages built:
|
superherointj
approved these changes
Jul 11, 2024
eclairevoyant
approved these changes
Jul 11, 2024
Contributor
Author
|
Result of 4 packages built:
|
sarahec
changed the title
sarahec
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes failing runtime dependencies check on Darwin via
pythonRemoveDeps. Tested on Linux x86 and both flavors of Darwin to ensure no regressions.Fixes #326167
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.